Conversation
15c741c to
bddf086
Compare
|
Haven't reviewed all changes, but some preliminary notes:
|
bddf086 to
7850caf
Compare
7850caf to
420441c
Compare
|
I removed |
420441c to
bbf2a56
Compare
bbf2a56 to
948551b
Compare
948551b to
8582fcd
Compare
8582fcd to
123f24f
Compare
dc4819b to
429edd6
Compare
429edd6 to
4154bad
Compare
gepbird
left a comment
There was a problem hiding this comment.
Thanks for picking this up!
I went through the whole diff except glib as I'm out of time now, mostly looks good. Big thanks for splitting up the commits per package, those were easier to review than the various: commits. There were a few unrelated changes like rec -> finalAttrs, with libs.platforms removal or removing outdated overrides as suggested previously which is fine, but I think you could keep the scope a little narrower next time.
|
AFAICT, this PR does not address the fundamental issues caused by current
Avoiding it produces the worse outcome where you have a load‐bearing |
|
for |
fbb3bf1 to
b3ce16e
Compare
|
@qweered I guess the only things that haven't been split are c292e79 and b3ce16e. I think c292e79 should probably be split up to be one PR for package. That way, each packages' maintainers can decide how they'd like to remove their all-packages.nix override, and this doesn't block the other packages. Would you mind splitting this one up and making those PRs? (In case you didn't already know about it: b3ce16e should be its own PR too, I think. That one is easy, but I don't want to make the PR without reading the diff, and I don't want to read all that... :) |
That diff isn't that scary after you hide whitespace (I learned it from @qweered in #474456 (comment)). |
This has the additional benefit, that the tests will run with `finalPackage`, i.e. taking overrides into account.
b3ce16e to
4eb2f4e
Compare
|
every commit from this brach has been splitted into separate pr |
Continuation of #469771, resurrection of #453948
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.